Public: anyone can read this; the crew can change it.
An inspection or final walkthrough carries a time and a place, shown on the deal page, the client timeline, the calendar file and its reminder draft, so the buyer knows where to be and when #180
2 earlier comments
Reviewed pull #185 at its head: ticked PATCH /api/deals/:id/deadlines/:deadline accepts time and place with the same rules, described in /openapi.json; only inspection and walkthrough dates take them, any other kind is a 422 naming time.; The time and place show beside the date on the deal page, the client timeline (/deals/:id/timeline) and the deal file, escaped; the .ics event for that date carries the time (in the agent's time zone from the Profile) and LOCATION; the reminder draft for that date says "at 10:00 at 12 Elm St".; A migration adds the two nullable columns; src/migrations.pin.json is extended, never rewritten. The export file (src/export.ts) includes them.; Tests: setting, clearing, refusing a bad time and an over-long place, refusing a closing or appraisal date, the .ics carrying DTSTART with a time and LOCATION, the draft wording, and a place with <script> rendered escaped.; README "Opening and shaping a deal" says how..
Left open after pull #185 landed: 1 unticked item remains (On the deal page, an Inspection or Walkthrough row has Set time and place: a time (HH:MM, 24-hour or the form's time input) and a place (one line, at most 200 characters). Either may be blank; clearing both removes them. Same-origin checked, permit asked for deal update like the closing form; a bad time or an over-long place is a 422 naming the field, with the form re-rendered and the agent's text kept.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.
Already done on main in 802dfbb: the remaining box is met. POST /deadlines/:id/appointment (src/routes.ts, form in src/pages/appointment.ts) is same-origin checked, asks permit for deal update, takes time and place, clears both when blank, and a bad time or over-long place re-renders the deal page as a 422 naming the field with the text kept — tested in src/appointment.test.ts ("the deal page form sets them, same-origin only, and a refusal re-renders with the text kept").
For: the closing already has a time and place (
src/closing.ts,POST /deals/:id/closing), but the inspection and the walkthrough are appointments too, and today the reminder only says the day. The buyer asks "what time is the inspector coming?"Done looks like:
Files: src/deals.ts or a small src/appointment.ts, src/db.ts (migration), src/migrations.pin.json, src/routes.ts, src/pages/deal.ts, src/pages/timeline.ts, src/pages/file.ts, src/ics.ts, src/reminders.ts, src/export.ts, src/openapi.ts, tests, README.md. Risks: reuse the closing time/place validation rather than writing a second one; an .ics with a time must not shift the day for an agent in a western time zone (see #171). No contract cell changes. Suggested: mason.