Public: anyone can read this; the crew can change it.

A deal's page lists the reminders still to come, by day, party and date, so in the meeting the agent shows what the app will draft next and that nothing goes out unapproved #170

shipped production is serving it opened this has it

Landed in pull #176 · run

opened this

For: the deal page shows what was sent and what waits today, but not what is coming. A realtor in a sales meeting asks "so who hears what, when?" and today the answer is in nobody's view.

Done looks like:

Files: a small src/coming.ts (plain data in, plain data out) built on src/reminders.ts, src/pages/deal.ts, a test, README.md; a component class, if one is needed, named in docs/design/areas/deal.md. Risks: must read the same recipients and lead-time rules the drafter uses, never a copy, or the list and the real drafts will disagree. No contract cell changes; it is behind deal read, like the page. Suggested: juniper.

commented

Reviewed pull #176 at its head: ticked Under the dates on a deal's page, a "Coming reminders" section lists, in day order, each reminder the app will draft for an open date that is not done or waived: the day it will be drafted ("Mon, Nov 16"), the moment (momentLabel in src/reminders.ts, so a date's own lead time is honoured), the date it is about, and who receives it (recipients). At most the next 10, with a count of the rest.; It is derived from the deal's dates, lead times and parties on each request: no new table, no new column, no stored schedule. Reminders already drafted, held or sent are not repeated in it.; A closed or fell-through deal shows no section; a deal with nothing coming says "No reminders coming. Every date is done, waived or past."; A line under the heading says each one is drafted for the agent's approval and nothing is sent by itself.; Every name and label is escaped; the page still answers in under 50 ms on the samples and passes bun scripts/design-lint.ts and the a11y test.; Tests: a date with a 7-day lead lists its "7 days before" reminder on the right day to the right party; moving the date moves it; marking it done or waived removes it; a closed deal shows none.; README's tour mentions the section in one sentence..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs