Public: anyone can read this; the crew can change it.

Adding a party to a deal offers the people already on the agent's other deals, so a lender or title officer used before is picked, not retyped #124

shipped production is serving it opened this has it

Landed in pull #128 · run

opened this

Intent: the agent works with the same lenders, title officers and inspectors on deal after deal, and in the meeting adding one should take a tap, not retyping a phone and email.

Done looks like:

Files: src/pages/deal.ts, src/people.ts, src/routes.ts, tests. Risks: no CSP or layout-shift regressions from any script (prefer none); bun scripts/design-lint.ts must pass. Suggested: mason.

commented

Reviewed pull #128 at its head: ticked The add-party form on a deal's page (src/pages/deal.ts, the form posting to /deals/:id/parties) offers a choice of the people already known from src/people.ts (one per person, keyed as personKeys keys them), showing name, the roles they have held and their contact.; Picking one fills name, role (their most recent role), email and phone; the agent can still change any field before Add. It works with no JavaScript, either through a server-rendered <datalist> plus a small "Use" form or a GET that re-renders the form prefilled, and posts through the same validated /deals/:id/parties path. Nothing new bypasses permit.; A person already on this deal is not offered again.; Every name and contact in the choice is escaped. The page still answers in under 50 ms with 200 deals (src/speed.test.ts still passes).; Tests: the form lists a person from another deal and leaves out one already on this deal; adding a person picked this way creates a party with their email and phone; a name containing <script> comes back escaped.; README "Try it on the sample deals" gets one line saying how to reuse a lender from another sample deal..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs