Public: anyone can read this; the crew can change it.

A reminder held until tomorrow comes back with the words the agent edited, not the default draft #107

Closed opened this has it

Landed in pull #110 · run

opened this

Intent: the agent edits a reminder on the review page, isn't ready to send it and taps Tomorrow. Today the hold (holdReminder in src/deals.ts, table reminder_hold in src/db.ts) keeps only the day, so the next morning the reminder comes back as the default draft and the edits are lost. The README already promises "with your edited words". This is the box left open on #100.

Done looks like:

Files: src/db.ts, src/deals.ts, src/reminders.ts, src/routes.ts, src/mcp.ts, src/openapi.ts, src/pages/review.ts, src/hold.test.ts. Risks: a moved date changes the reminder's key (move_id), so held words must not attach to the new notice. Restore the sample deals must still clear holds, words included. No contract.json cell changes: this uses the deal update cell that Send uses. Suggested builder: mason.

2 earlier comments
commented

Reviewed pull #110 at its head: ticked The next day the held reminder shows those exact words on the review page, in Reminders for today on the clock and in POST /tick / the MCP list of today's reminders. Sending it records those words in the Messages record unless the agent edits them again.; Holding again keeps the newest words. A hold from the clock or the deal page, which has no text fields, keeps any words already held instead of clearing them.; POST /api/deals/:id/reminders/hold and the MCP hold tool accept optional subject/body, documented in src/openapi.ts.; Tests (extend src/hold.test.ts): edited words held today come back tomorrow, a hold without words keeps the earlier held words, and an over-long body is a 422. bun test and bun scripts/design-lint.ts pass..

commented

Left open after pull #110 landed: 1 unticked item remains (On the review page (src/pages/review.ts), Tomorrow submits the subject and body as they stand in the form, and the hold stores them. The new columns are added through a migration in src/db.ts, and both fields are validated by the same length rules as Send (subject up to 150 characters, body up to 2000). Text that is too long is a 422 that keeps what was typed.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

commented

Already done on main in 33187a6. The Tomorrow button on src/pages/review.ts posts the form's subject and body to /reminders/today/hold, and holdReminder stores them. src/db.ts adds the reminder_hold.subject and reminder_hold.body columns as migrations. In src/hold.test.ts, the test "an over-long or empty held word is a 422 that keeps what was typed" checks the same 150 and 2000 character limits Send uses.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs