Public: anyone can read this; the crew can change it.

The agent changes who owes a date after it is added, and its reminders from then on go to the new party #102

Closed opened this has it

Landed in pull #104 · run

opened this

Intent: "Owed by" can be chosen only when a date is added (src/pages/deal.ts). A date entered against the wrong party, or one the contract hands from the buyer to the seller (a repair, say), can't be corrected. The only way to fix it is to remove the date and type it again, which loses its history.

Done looks like:

Files: src/routes.ts, src/deals.ts, src/mcp.ts, src/openapi.ts, src/activity.ts, src/pages/deal.ts, src/pages/clock.ts, README.md, plus a new src/owes.test.ts.

Risks: reminders are remembered by deadline, party and move. Changing who owes must not mark the new party's reminder as already sent, and must not bring back the old party's declined one. If #100 lands first, holds on the old party's reminder should be dropped.

Suggested builder: mason.

commented

Reviewed pull #104 at its head: ticked Each open date on the deal's page, and in the marker panel on the clock, has an Owed by select with the same choices as Add a date. It is a POST form that works without JavaScript, passes the same-origin check and is allowed through permit on the deal update cell. No contract cell changes.; A role that is not one of PARTY_ROLES is refused with 422, and the form keeps what was typed. A done or waived date can't be changed, and gets a 409 that says why.; After the change, every page and output that names who owes the date names the new party: the deal page, clock marker, This week, People page, client timeline, sheets, calendar files and spreadsheet. Today's reminders and any later ones are drafted to the new party. Reminders already sent, and the Messages record, stay as they were.; The API (PATCH /api/deals/:id/deadlines/:deadline accepts owes, documented in src/openapi.ts) and the MCP tools can change it too.; There are tests for: a change moves today's draft to the new party, the People page lists the date under the new party, a bad role is a 422, a settled date is a 409, a change from another origin is refused, and an anonymous visitor is refused. bun test and bun scripts/design-lint.ts pass.; One README sentence says the agent can change who owes a date.. left open: The deal's Activity record and the admin Activity page show "owed by changed from Buyer to Seller by <name>". — Only the admin Activity page shows it; the deal page has no Activity record..

commented

Left open after pull #104 landed: 1 unticked item remains (The deal's Activity record and the admin Activity page show "owed by changed from Buyer to Seller by <name>".). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs