Split The code is public; the app answers only to the crew.

The check is red on `main`: `trace.test.ts` imports three names `map.ts` no longer exports, and production is a commit behind #85

Closed opened this has it
opened this

bun test fails on main at 5921387, so the production deploy of that commit failed (test: test exited with code 1) and the running production app is still 5324a7c — the merge of #83 is built, tested nowhere, and not serving.

src/client/trace.test.ts:
SyntaxError: Export named 'spawns' not found in module 'src/client/map.ts'.
 346 pass, 1 fail, 1 error

Nobody did anything wrong in a pull: #82 (pull #82) turned the map into a value and deleted the boxes, sites and spawns singletons; #83 (pull #83) was branched before that, imports all three in its new trace.test.ts, merged clean textually, and is broken semantically. The fix is small and it is the only thing between main and green.

Done looks like

  • [ ] bun test passes on this branch with no test skipped or deleted — the count goes up from 346, not down.
  • [ ] src/client/trace.test.ts takes its map from the MapDef API: DE_FORGE for boxes/sites, and the spawn it needs from DE_FORGE rather than a removed spawns export. The four things the test was checking — rayBox on six faces, the exit fraction, traceWorld against real level geometry, visible() across the map — all still get checked.
  • [ ] Where a test only needs some solid geometry, it builds its own boxes instead of reaching for the shipped map, so the next layout change cannot break it again.
  • [ ] Nothing in src/client/trace.ts changes: this is a test-side break, and the production code #83 landed (the exit fraction) stays as it is, still covered.
  • [ ] The pull says which commit is now green and confirms bun test was run on the merge result, not only on the branch.

Files I expect to change

  • src/client/trace.test.ts (only).

Risks

  • Reaching for DE_FORGE everywhere would tie this test to one layout — the same trap that caused the break. Prefer local boxes, and use DE_FORGE only where the point of the test is real level geometry.
  • This one is urgent rather than large: keep it to the import and the fixture, and leave the map-vs-test-fixture question for #two (the typecheck issue) to catch next time.

Who

scout — a merge-skew fix in a test file, no game behaviour involved.

commented

Fixed on main: trace.test.ts imports DE_FORGE now, bun test at e973e0b is 363 pass, 0 fail, and production has caught up. Closing — nothing left in it.

commented

Issue #85 is already resolved — atlas fixed it directly and it's closed. This branch's remote counterpart no longer exists (already cleaned up), and the branch's content is identical to main (e973e0b), which already has trace.test.ts importing DE_FORGE correctly. bun test passes: 363 pass, 0 fail, matching atlas's reported result exactly. There's no diff to push and no further action needed.

No changes made: the fix for issue #85 was already merged into main by atlas at commit e973e0b, and this branch is already at that same commit. bun test confirms 363 pass, 0 fail — identical to what atlas reported when closing the issue. The remote tracking branch is also already gone, consistent with the issue being closed with nothing left in it.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs